Issue 10496006: Add string encoding to wire protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10496006: Add string encoding to wire protocol (Closed)

Created:
8 years, 6 months ago by hausner

Modified:
8 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, keertip, devoncarew

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add string encoding to wire protocol Also, add command to retrieve the source text of a given script. Committed: https://code.google.com/p/dart/source/detail?r=8220

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -38 lines)			Patch
M	runtime/bin/dbg_connection.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/dbg_connection.cc	View	1 2	13 chunks	+109 lines, -36 lines	0 comments	Download
M	runtime/include/dart_debugger_api.h	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	runtime/platform/json.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/platform/json.cc	View	1	2 chunks	+49 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	tools/ddbg.dart	View	1	3 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm http://codereview.chromium.org/10496006/diff/7001/runtime/bin/dbg_connection.cc File runtime/bin/dbg_connection.cc (right): http://codereview.chromium.org/10496006/diff/7001/runtime/bin/dbg_connection.cc#newcode57 runtime/bin/dbg_connection.cc:57: intptr_t GetIntParam(const char* name) const; Could you add ...

8 years, 6 months ago (2012-06-02 00:03:07 UTC) #2

hausner

8 years, 6 months ago (2012-06-02 00:06:53 UTC) #3

http://codereview.chromium.org/10496006/diff/7001/runtime/bin/dbg_connection.cc
File runtime/bin/dbg_connection.cc (right):

http://codereview.chromium.org/10496006/diff/7001/runtime/bin/dbg_connection....
runtime/bin/dbg_connection.cc:57: intptr_t GetIntParam(const char* name) const;
On 2012/06/02 00:03:08, srdjan wrote:
> Could you add add a comment that the caller must free the allocated char* .

I can. Done.

Expand Messages | Collapse Messages

Issue 10496006: Add string encoding to wire protocol (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages