Move inlined type checking code to new compiler ia32. Sharing more and more code between ia32/x64 (…

Move inlined type checking code to new compiler ia32. Sharing more and more code between ia32/x64 (ongoing process), refactored x64 code slightly.
Committed: https://code.google.com/p/dart/source/detail?r=8292

[Vyacheslav Egorov (Google), 2012-06-05 12:52:24]

lgtm

Tons of duplicated non-trival code between ia32/x64 which is different only in
sizes of mov/push/cmp instructions and sometimes a little bit in register
constraints worry me a lot. We should definitely think about abstracting this
away.

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:430: RawSubtypeTestCache*
FlowGraphCompiler::GenerateCallSubtypeTestStub(
comment that it clobbers ECX?

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:461: __ popl(temp_reg);  // Discard.
instance reg and temp_reg should not be ECX. assert?

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:547: // EAX: instance to test against
(preserved). Clobbers ECX.
clobbers ebx as well

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:559: __ testl(EAX,
Immediate(kSmiTagMask));
declare named constants for registers just like above?

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:594: __ LoadClass(ECX, EAX, EBX);
on x64 we have LoadClassById (ECX already contains id).

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:654: // For Smi check quickly against int
and num interfaces.
indentation

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_x64.cc:190: __ cmpl(R10,
Immediate(class_ids[i]));
class_id_reg here?

[srdjan, 2012-06-05 15:32:20]

Thanks for the prompt review. Yes, the almost identical code must be merged. One
way would be to have common assembly operations, but I think I'd rather prefer a
factorization into flow graph nodes. We need to consider future type analysis
and the best way to present the nodes to type-check elimination pass.

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:430: RawSubtypeTestCache*
FlowGraphCompiler::GenerateCallSubtypeTestStub(
On 2012/06/05 12:52:24, Vyacheslav Egorov (Google) wrote:
> comment that it clobbers ECX?

Done.

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:461: __ popl(temp_reg);  // Discard.
On 2012/06/05 12:52:24, Vyacheslav Egorov (Google) wrote:
> instance reg and temp_reg should not be ECX. assert?

Done.

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:547: // EAX: instance to test against
(preserved). Clobbers ECX.
On 2012/06/05 12:52:24, Vyacheslav Egorov (Google) wrote:
> clobbers ebx as well

Removed LoadClass usage, EBX not clobbered any longer.

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:559: __ testl(EAX,
Immediate(kSmiTagMask));
On 2012/06/05 12:52:24, Vyacheslav Egorov (Google) wrote:
> declare named constants for registers just like above?

Done.

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:594: __ LoadClass(ECX, EAX, EBX);
On 2012/06/05 12:52:24, Vyacheslav Egorov (Google) wrote:
> on x64 we have LoadClassById (ECX already contains id).

Added LoadClassById

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.cc:654: // For Smi check quickly against int
and num interfaces.
On 2012/06/05 12:52:24, Vyacheslav Egorov (Google) wrote:
> indentation

Done.

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://chromiumcodereview.appspot.com/10477020/diff/10001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_x64.cc:190: __ cmpl(R10,
Immediate(class_ids[i]));
On 2012/06/05 12:52:24, Vyacheslav Egorov (Google) wrote:
> class_id_reg here?

Done.