Issue 10477010: Fix some editor warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10477010: Fix some editor warnings. (Closed)

Created:
8 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 6 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix some editor warnings. Committed: https://code.google.com/p/dart/source/detail?r=8248

Patch Set 2 : Address review comment. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -20 lines)			Patch
M	lib/compiler/implementation/operations.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1	3 chunks	+3 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/ssa/variable_allocator.dart	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://chromiumcodereview.appspot.com/10477010/diff/1/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/10477010/diff/1/lib/compiler/implementation/ssa/nodes.dart#newcode2380 lib/compiler/implementation/ssa/nodes.dart:2380: int visitNode(Node node) => -1; NOT_A_LOOP?

8 years, 6 months ago (2012-06-04 11:54:32 UTC) #2

Lasse Reichstein Nielsen

8 years, 6 months ago (2012-06-04 12:09:17 UTC) #3

https://chromiumcodereview.appspot.com/10477010/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10477010/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/nodes.dart:2380: int visitNode(Node node) => -1;
On 2012/06/04 11:54:32, karlklose wrote:
> NOT_A_LOOP?

Done.

Expand Messages | Collapse Messages

Issue 10477010: Fix some editor warnings. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comment. #

Messages