Issue 10459053: Real fix for breakage: if type in DECLARE_FLAG differs from DEFINE_FLAG, windows compiler is the on…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10459053: Real fix for breakage: if type in DECLARE_FLAG differs from DEFINE_FLAG, windows compiler is the on… (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Real fix for breakage: if type in DECLARE_FLAG differs from DEFINE_FLAG, windows compiler is the only one who complains. Bravo! Committed: https://code.google.com/p/dart/source/detail?r=8171

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

lgtm