Issue 10459023: Move ExtractConstructorTypeArguments and CatchEntry to new location template.

Issue 10459023: Move ExtractConstructorTypeArguments and CatchEntry to new location template. (Closed)

Created:
8 years, 6 months ago by regis

Modified:
8 years, 6 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move ExtractConstructorTypeArguments and CatchEntry to new location template. Committed: https://code.google.com/p/dart/source/detail?r=8107

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -56 lines)			Patch
	M	runtime/vm/flow_graph_compiler_x64.cc	View	1	2 chunks	+4 lines, -52 lines	0 comments	Download
	M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+65 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://chromiumcodereview.appspot.com/10459023/diff/1/runtime/vm/intermediate_language_x64.cc File runtime/vm/intermediate_language_x64.cc (right): https://chromiumcodereview.appspot.com/10459023/diff/1/runtime/vm/intermediate_language_x64.cc#newcode800 runtime/vm/intermediate_language_x64.cc:800: Register result_reg = locs()->out().reg(); I'd add ASSERT(result_reg == ...

8 years, 6 months ago (2012-05-30 15:04:12 UTC) #2

regis

Thanks! https://chromiumcodereview.appspot.com/10459023/diff/1/runtime/vm/intermediate_language_x64.cc File runtime/vm/intermediate_language_x64.cc (right): https://chromiumcodereview.appspot.com/10459023/diff/1/runtime/vm/intermediate_language_x64.cc#newcode800 runtime/vm/intermediate_language_x64.cc:800: Register result_reg = locs()->out().reg(); On 2012/05/30 15:04:12, Florian ...

8 years, 6 months ago (2012-05-30 15:09:09 UTC) #3

lgtm

Expand Messages | Collapse Messages