Issue 10459006: Status file update to have dart2js/chrome/mac green.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10459006: Status file update to have dart2js/chrome/mac green. (Closed)

Created:
8 years, 6 months ago by ngeoffray

Modified:
8 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Status file update to have dart2js/chrome/mac green. Committed: https://code.google.com/p/dart/source/detail?r=8037

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -7 lines)			Patch
M	dart/samples/tests/samples/samples.status	View	2 chunks	+5 lines, -1 line	1 comment	Download
M	dart/tests/html/html.status	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	dart/tests/isolate/isolate.status	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	dart/tests/utils/utils.status	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kasperl

8 years, 6 months ago (2012-05-29 09:24:57 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/10459006/diff/1/dart/samples/tests/sam...
File dart/samples/tests/samples/samples.status (right):

https://chromiumcodereview.appspot.com/10459006/diff/1/dart/samples/tests/sam...
dart/samples/tests/samples/samples.status:66: lib/touch/touch_test: Fail #
Expectation: Solver. Expect.approxEquals(expected:9, actual:8.990625000000001,
tolerance:0.0009) fails</td
File bug for this so we don't lose track?

https://chromiumcodereview.appspot.com/10459006/diff/1/dart/tests/html/html.s...
File dart/tests/html/html.status (right):

https://chromiumcodereview.appspot.com/10459006/diff/1/dart/tests/html/html.s...
dart/tests/html/html.status:176: element_test: Fail # method not found:
'get$add'
Maybe we should do a pass through all these files later and file bugs?

Expand Messages | Collapse Messages