Issue 10458054: Ignore the growth policy when fragmentation prevents allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10458054: Ignore the growth policy when fragmentation prevents allocation. (Closed)

Created:
8 years, 6 months ago by cshapiro

Modified:
8 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ignore the growth policy when fragmentation prevents allocation. Committed: https://code.google.com/p/dart/source/detail?r=8138

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/vm/pages.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://chromiumcodereview.appspot.com/10458054/diff/1/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://chromiumcodereview.appspot.com/10458054/diff/1/runtime/vm/pages.cc#newcode203 runtime/vm/pages.cc:203: (size < (capacity() - in_use()))) && // Fragmentation The ...

8 years, 6 months ago (2012-05-31 23:32:53 UTC) #2

Ivan Posva

8 years, 6 months ago (2012-05-31 23:33:22 UTC) #3

On 2012/05/31 23:32:53, Ivan Posva wrote:
> https://chromiumcodereview.appspot.com/10458054/diff/1/runtime/vm/pages.cc
> File runtime/vm/pages.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10458054/diff/1/runtime/vm/pages.cc#ne...
> runtime/vm/pages.cc:203: (size < (capacity() - in_use()))) &&  //
Fragmentation
> The problem with this solution is that it has no memory. The likelihood of
> allowing growth is too high.

LGTM for the build break fix.

-Ivan

Expand Messages | Collapse Messages