Issue 10458050: Move ReturnInstr to new scheme (x64 and ia32) and implement more code in new ia32 compiler.

Issue 10458050: Move ReturnInstr to new scheme (x64 and ia32) and implement more code in new ia32 compiler. (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move ReturnInstr to new scheme (x64 and ia32) and implement more code in new ia32 compiler. Committed: https://code.google.com/p/dart/source/detail?r=8166

Patch Set 5 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+438 lines, -169 lines)			Patch
M	runtime/vm/assembler_ia32.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2 3 4	2 chunks	+28 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3 4	1 chunk	+61 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3 4	3 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4	1 chunk	+4 lines, -60 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4	1 chunk	+1 line, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4	5 chunks	+12 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4	31 chunks	+213 lines, -52 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4	22 chunks	+93 lines, -32 lines	0 comments	Download
M	runtime/vm/locations.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/locations.cc	View	1 2 3 4	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

LGTM https://chromiumcodereview.appspot.com/10458050/diff/3002/runtime/vm/flow_graph_compiler_ia32.cc File runtime/vm/flow_graph_compiler_ia32.cc (right): https://chromiumcodereview.appspot.com/10458050/diff/3002/runtime/vm/flow_graph_compiler_ia32.cc#newcode334 runtime/vm/flow_graph_compiler_ia32.cc:334: ICData& ic_data = ICData::ZoneHandle(ICData::New(parsed_function_.function(), This function seems to ...

8 years, 6 months ago (2012-05-31 12:11:01 UTC) #2

srdjan

8 years, 6 months ago (2012-05-31 16:24:39 UTC) #3

https://chromiumcodereview.appspot.com/10458050/diff/3002/runtime/vm/flow_gra...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://chromiumcodereview.appspot.com/10458050/diff/3002/runtime/vm/flow_gra...
runtime/vm/flow_graph_compiler_ia32.cc:334: ICData& ic_data =
ICData::ZoneHandle(ICData::New(parsed_function_.function(),
On 2012/05/31 12:11:01, Vyacheslav Egorov (Google) wrote:
> This function seems to duplicate considerable amount of code from
> CodeGenerator::GenerateInstanceCall. 
> 
> Consider sharing.

Know how to do it, but requires a major change in the structure of
FlowGraphCompiler, next CL.

https://chromiumcodereview.appspot.com/10458050/diff/3002/runtime/vm/flow_gra...
runtime/vm/flow_graph_compiler_ia32.cc:366: const Array& arguments_descriptor =
On 2012/05/31 12:11:01, Vyacheslav Egorov (Google) wrote:
> This function duplicates code from CodeGenerator::VisitStaticCallNode 
> 
> Consider sharing.

Done.

Expand Messages | Collapse Messages