Issue 10458027: Started new compiler for ia32. Getters and setters can be intrinsified within the new compiler.

Issue 10458027: Started new compiler for ia32. Getters and setters can be intrinsified within the new compiler. (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Florian Schneider, regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Started new compiler for ia32. Getters and setters can be intrinsified within the new compiler. Committed: https://code.google.com/p/dart/source/detail?r=8116

Patch Set 5 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+841 lines, -29 lines)			Patch
runtime/vm/assembler_ia32.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
runtime/vm/assembler_ia32.cc	View	1 2 3	1 chunk	+9 lines, -2 lines	0 comments	Download
runtime/vm/flow_graph_compiler_ia32.h	View	1 2 3	3 chunks	+61 lines, -7 lines	0 comments	Download
runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3	2 chunks	+385 lines, -6 lines	0 comments	Download
runtime/vm/flow_graph_compiler_x64.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	2 chunks	+9 lines, -2 lines	0 comments	Download
runtime/vm/intermediate_language_ia32.cc	View	1 2 3	1 chunk	+375 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10458027/diff/8002/runtime/vm/flow_graph_compiler_ia32.cc File runtime/vm/flow_graph_compiler_ia32.cc (right): https://chromiumcodereview.appspot.com/10458027/diff/8002/runtime/vm/flow_graph_compiler_ia32.cc#newcode262 runtime/vm/flow_graph_compiler_ia32.cc:262: // Total number of args is the first ...

8 years, 6 months ago (2012-05-30 08:58:20 UTC) #2

Florian Schneider

lgtm https://chromiumcodereview.appspot.com/10458027/diff/8002/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10458027/diff/8002/runtime/vm/intermediate_language_ia32.cc#newcode17 runtime/vm/intermediate_language_ia32.cc:17: void ClassName::EmitNativeCode(FlowGraphCompiler* compiler) { \ May also add ...

8 years, 6 months ago (2012-05-30 15:06:23 UTC) #3

srdjan

https://chromiumcodereview.appspot.com/10458027/diff/8002/runtime/vm/flow_graph_compiler_ia32.cc File runtime/vm/flow_graph_compiler_ia32.cc (right): https://chromiumcodereview.appspot.com/10458027/diff/8002/runtime/vm/flow_graph_compiler_ia32.cc#newcode262 runtime/vm/flow_graph_compiler_ia32.cc:262: // Total number of args is the first Smi ...

8 years, 6 months ago (2012-05-30 16:20:39 UTC) #4

srdjan

8 years, 6 months ago (2012-05-30 16:31:19 UTC) #5

https://chromiumcodereview.appspot.com/10458027/diff/8002/runtime/vm/intermed...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10458027/diff/8002/runtime/vm/intermed...
runtime/vm/intermediate_language_ia32.cc:17: void
ClassName::EmitNativeCode(FlowGraphCompiler* compiler) {       \
On 2012/05/30 15:06:24, Florian Schneider wrote:
> May also add the empty definitions of EmitNativeCode below and get rid of the
> DEFINE_UNIMPLEMENTED completely?

Done.

Expand Messages | Collapse Messages