Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Issue 10456060: Eliminate unary plus with hex literals (Closed)

Created:
8 years, 6 months ago by hausner
Modified:
8 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Eliminate unary plus with hex literals The spec says unary + is only allowed with integer and floating point literals, not with hex literals. Somebody noticed that the VM accepted +0x10 as well. Consequently, the Math.parseInt(str) library function should fail with a BadNumberFormatException if it is called with a hex number that is preceded by a +. Fixes issue 1540. This change exposed that the dart2js core library implementation is falsely accepting +0xNNN hex numbers. I filed issue 3333. Committed: https://code.google.com/p/dart/source/detail?r=8177

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M runtime/vm/scanner.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M tests/co19/co19-leg.status View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/math_parse_double_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/corelib/math_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
Itsy bitsy review.
8 years, 6 months ago (2012-05-31 18:30:51 UTC) #1
srdjan
8 years, 6 months ago (2012-05-31 19:06:22 UTC) #2
LGTM after testing there are no failures in other components.

Powered by Google App Engine
This is Rietveld 408576698