Wrapperless dart:html for Dartium.

Wrapperless dart:html for Dartium.


R=antonm@google.com,sra@google.com,vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=8113

[Anton Muhin, 2012-05-30 00:18:47]

Another unreviewable CL, but that's how one learns to trust another :)

Jokes aside, awesome achievement, Pavel, thanks a lot!

LGTM

https://chromiumcodereview.appspot.com/10456006/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/dartium/impl_EventTarget.darttemplate (right):

https://chromiumcodereview.appspot.com/10456006/diff/1/lib/dom/templates/html...
lib/dom/templates/html/dartium/impl_EventTarget.darttemplate:107: /*
wow, maybe just remove?

[podivilov, 2012-05-30 16:02:55]

Thanks!

https://chromiumcodereview.appspot.com/10456006/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/dartium/impl_EventTarget.darttemplate (right):

https://chromiumcodereview.appspot.com/10456006/diff/1/lib/dom/templates/html...
lib/dom/templates/html/dartium/impl_EventTarget.darttemplate:107: /*
On 2012/05/30 00:18:47, antonmuhin wrote:
> wow, maybe just remove?

It would break the generation because of $!MEMBERS sub-emitter. Let me fix this
in a separate cl.

[vsm, 2012-05-31 05:22:20]

https://chromiumcodereview.appspot.com/10456006/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10456006/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:818: INTERFACE=typename,
Pavel, this change is breaking html_frog.  We're getting assignability errors of
the following form:

/usr/local/google/vsm/dart-all/dart/lib/html/frog/html_frog.dart:35676:32:
error: type "html._ElementImpl" is not assignable to "html.BodyElement"
    BodyElement _e = _document.$dom_createElement("body");

after refreshing html_frog.dart and running a clean (./tools/build.py) build in
the main dart repo.

[podivilov, 2012-05-31 16:07:11]

Old version:
_AnchorElementImpl _e = _document.$dom_createElement("a");

New version:
AnchorElement _e = _document.$dom_createElement("a");

Old version doesn't work in Dartium, because implementation classes are named
after idl interfaces: _ElementImpl, _HTMLElementImpl, _HTMLAnchorElement etc. So
there is no class named _AnchorElementImpl.

New version doesn't work in frog, because _DocumentImpl.$dom_createElement is
declared to return narrowed type _ElementImpl which is unrelated to
AnchorElement interface.

There are several ways to fix that:
1) Generate another version of _Elements.dart for Dartium
2) Generate "var _e = _document.$dom_createElement("a");" for both systems
3) Use interfaces as return types in frog implementations.
...

Which one is better?

[sra1, 2012-05-31 18:17:17]

On 2012/05/31 16:07:11, podivilov wrote:
> Old version:
> _AnchorElementImpl _e = _document.$dom_createElement("a");
> 
> New version:
> AnchorElement _e = _document.$dom_createElement("a");
> 
> Old version doesn't work in Dartium, because implementation classes are named
> after idl interfaces: _ElementImpl, _HTMLElementImpl, _HTMLAnchorElement etc.
So
> there is no class named _AnchorElementImpl.
> 
> New version doesn't work in frog, because _DocumentImpl.$dom_createElement is
> declared to return narrowed type _ElementImpl which is unrelated to
> AnchorElement interface.
> 
> There are several ways to fix that:
> 1) Generate another version of _Elements.dart for Dartium
> 2) Generate "var _e = _document.$dom_createElement("a");" for both systems
> 3) Use interfaces as return types in frog implementations.
> ...
> 
> Which one is better?

Can we generate the old version for frog and the new version for Dartium?
We generate different factory constructors for frog vs dartium for other
classes.
The VM can use run-time types so I'm not so worried about the type annotation
there.

[sra1, 2012-05-31 21:19:56]

On 2012/05/31 18:17:17, sra1 wrote:
> On 2012/05/31 16:07:11, podivilov wrote:
> > Old version:
> > _AnchorElementImpl _e = _document.$dom_createElement("a");
> > 
> > New version:
> > AnchorElement _e = _document.$dom_createElement("a");
> > 
> > Old version doesn't work in Dartium, because implementation classes are
named
> > after idl interfaces: _ElementImpl, _HTMLElementImpl, _HTMLAnchorElement
etc.
> So
> > there is no class named _AnchorElementImpl.
> > 
> > New version doesn't work in frog, because _DocumentImpl.$dom_createElement
is
> > declared to return narrowed type _ElementImpl which is unrelated to
> > AnchorElement interface.
> > 
> > There are several ways to fix that:
> > 1) Generate another version of _Elements.dart for Dartium
> > 2) Generate "var _e = _document.$dom_createElement("a");" for both systems
> > 3) Use interfaces as return types in frog implementations.
> > ...
> > 
> > Which one is better?
> 
> Can we generate the old version for frog and the new version for Dartium?
> We generate different factory constructors for frog vs dartium for other
> classes.
> The VM can use run-time types so I'm not so worried about the type annotation
> there.

I will fix this by generating two files.