Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 10454112: Remove frog from the SDK and stop running it from the editor. (Closed)

Created:
8 years, 6 months ago by kasperl
Modified:
8 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove frog from the SDK and stop running it from the editor. R=johnniwinther@google.com,dgrove@google.com,devoncarew@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8231

Patch Set 1 #

Total comments: 2

Patch Set 2 : Keep import_*.config. #

Patch Set 3 : dev->sdk #

Patch Set 4 : Never map to .js_. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -155 lines) Patch
M client/dart.js View 1 2 3 1 chunk +3 lines, -15 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/frog/FrogCompiler.java View 1 chunk +1 line, -31 lines 0 comments Download
D lib/config/import_frog.config View 1 1 chunk +0 lines, -38 lines 0 comments Download
M lib/dartdoc/dartdoc.dart View 1 2 3 chunks +3 lines, -8 lines 0 comments Download
M tools/create_sdk.py View 1 2 8 chunks +35 lines, -63 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kasperl
I plan on landing this on Monday after addressing your comments. This changes break dartdoc ...
8 years, 6 months ago (2012-06-01 09:21:23 UTC) #1
devoncarew
lgtm Looks good from the editor's side -
8 years, 6 months ago (2012-06-01 09:33:52 UTC) #2
devoncarew
On 2012/06/01 09:33:52, devoncarew wrote: > lgtm > > Looks good from the editor's side ...
8 years, 6 months ago (2012-06-01 17:25:48 UTC) #3
dgrove
lgtm assuming the editor doesn't actual need the config files any longer. https://chromiumcodereview.appspot.com/10454112/diff/1/tools/create_sdk.py File tools/create_sdk.py ...
8 years, 6 months ago (2012-06-01 18:00:31 UTC) #4
devoncarew
https://chromiumcodereview.appspot.com/10454112/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10454112/diff/1/tools/create_sdk.py#newcode462 tools/create_sdk.py:462: # Copy dart2js. On 2012/06/01 18:00:32, dgrove wrote: > ...
8 years, 6 months ago (2012-06-03 16:38:39 UTC) #5
kasperl
8 years, 6 months ago (2012-06-04 06:47:23 UTC) #6
Thank you for your comments. I've re-added the import_*.config files, updated
frog_options.dart to use the 'sdk' configuration, and changed dartdoc to use
dart2js to compile its output.

Powered by Google App Engine
This is Rietveld 408576698