Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 10454005: Make sure [this] is available for super sends. (Closed)

Created:
8 years, 7 months ago by ahe
Modified:
8 years, 7 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, floitsch, karlklose, kasperl
Visibility:
Public.

Description

Make sure [this] is available for super sends. Committed: https://code.google.com/p/dart/source/detail?r=7942

Patch Set 1 #

Patch Set 2 : Add test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M dart/lib/compiler/implementation/ssa/closure.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A dart/tests/language/closure_with_super_send_test.dart View 1 1 chunk +25 lines, -0 lines 0 comments Download
M dart/tests/language/language.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
8 years, 7 months ago (2012-05-24 10:32:57 UTC) #1
ngeoffray
LGTM with a test fix or new test.
8 years, 7 months ago (2012-05-24 10:37:26 UTC) #2
ahe
PTAL, I had expected that co19 would find this, but no. So I wrote a ...
8 years, 7 months ago (2012-05-24 10:59:42 UTC) #3
ngeoffray
8 years, 7 months ago (2012-05-24 11:06:39 UTC) #4
STV!

Powered by Google App Engine
This is Rietveld 408576698