Issue 10453110: Implement optimized unary ops for ia32 as well. Fix a crash in disassembler.

Issue 10453110: Implement optimized unary ops for ia32 as well. Fix a crash in disassembler. (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), Florian Schneider, regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement optimized unary ops for ia32 as well. Fix a crash in disassembler. Committed: https://code.google.com/p/dart/source/detail?r=8211

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -11 lines)			Patch
M	runtime/vm/disassembler_ia32.cc	View	1 2	1 chunk	+8 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	2 chunks	+98 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://chromiumcodereview.appspot.com/10453110/diff/4001/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10453110/diff/4001/runtime/vm/intermediate_language_ia32.cc#newcode692 runtime/vm/intermediate_language_ia32.cc:692: __ movl(result, EAX); You could avoid the mov ...

8 years, 6 months ago (2012-06-01 15:49:10 UTC) #2

srdjan

https://chromiumcodereview.appspot.com/10453110/diff/4001/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10453110/diff/4001/runtime/vm/intermediate_language_ia32.cc#newcode692 runtime/vm/intermediate_language_ia32.cc:692: __ movl(result, EAX); On 2012/06/01 15:49:10, Florian Schneider wrote: ...

8 years, 6 months ago (2012-06-01 18:27:24 UTC) #3

Florian Schneider

8 years, 6 months ago (2012-06-02 18:54:11 UTC) #4

https://chromiumcodereview.appspot.com/10453110/diff/4001/runtime/vm/intermed...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10453110/diff/4001/runtime/vm/intermed...
runtime/vm/intermediate_language_ia32.cc:692: __ movl(result, EAX);
Ok, I meant more along this here without changing the constraints:

if (result != EAX) __ movl(result, EAX);

On 2012/06/01 18:27:25, srdjan wrote:
> On 2012/06/01 15:49:10, Florian Schneider wrote:
> > You could avoid the mov if result is already EAX.
> 
> Unless preformance/code-size is hurt, I'd like to keep the locations as
generic
> as possible. This one move does not matter and when we have efficient versions
> (e.g.,  for mixed double/Smi negation), the result will not need to be in EAX.

Expand Messages | Collapse Messages