Issue 10453098: Move Throw and ReThrow to the location based code generation.

Issue 10453098: Move Throw and ReThrow to the location based code generation. (Closed)

Created:
8 years, 6 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 6 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move Throw and ReThrow to the location based code generation. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=8163

Patch Set 2 : Move Branch as well, introduce base class for instruction with inputs #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -47 lines)			Patch
M	runtime/vm/flow_graph_compiler_x64.h	View	1	2 chunks	+19 lines, -4 lines	1 comment	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+6 lines, -29 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	11 chunks	+38 lines, -7 lines	1 comment	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+70 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM with one comment: https://chromiumcodereview.appspot.com/10453098/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10453098/diff/1/runtime/vm/intermediate_language.h#newcode1840 runtime/vm/intermediate_language.h:1840: LocationSummary* locs_; Can this be ...

8 years, 6 months ago (2012-05-31 13:32:25 UTC) #2

srdjan

8 years, 6 months ago (2012-05-31 16:00:52 UTC) #5

DBC

https://chromiumcodereview.appspot.com/10453098/diff/4001/runtime/vm/flow_gra...
File runtime/vm/flow_graph_compiler_x64.h (right):

https://chromiumcodereview.appspot.com/10453098/diff/4001/runtime/vm/flow_gra...
runtime/vm/flow_graph_compiler_x64.h:64: }
I think we can move both of these implementations into .cc file.

https://chromiumcodereview.appspot.com/10453098/diff/4001/runtime/vm/intermed...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10453098/diff/4001/runtime/vm/intermed...
runtime/vm/intermediate_language.h:1467: LocationSummary* locs_;
Add DISALLOW_COPY_AND_ASSIGN.

Generally I am not in favor of adding class hierarchies for code reuse only, but
only if we are going to use its type (i.e., InstructionWithInputs). I am OK with
it here & now, but I think we need to rethink the idea of instructions with
inputs once Kevin is back.

Expand Messages | Collapse Messages