Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 10453096: Use the parameterNames map to allocate names for HParameterValue. In case of native methods, we mus… (Closed)

Created:
8 years, 6 months ago by ngeoffray
Modified:
8 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use the parameterNames map to allocate names for HParameterValue. In case of native methods, we must not mangle the name. Committed: https://code.google.com/p/dart/source/detail?r=8146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M dart/lib/compiler/implementation/ssa/codegen.dart View 1 chunk +2 lines, -1 line 0 comments Download
M dart/lib/compiler/implementation/ssa/variable_allocator.dart View 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
8 years, 6 months ago (2012-05-31 10:16:14 UTC) #1
kasperl
8 years, 6 months ago (2012-05-31 10:19:44 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698