Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 10453079: Added i18n skeleton API for message_formatting (Closed)

Created:
8 years, 6 months ago by Emily Fortuna
Modified:
8 years, 6 months ago
CC:
reviews_dartlang.org, Alan Knight
Visibility:
Public.

Description

Added i18n skeleton API for message_formatting BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8131

Patch Set 1 #

Patch Set 2 : Adding dateFormat #

Patch Set 3 : Fixed typing of date_formatting #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -0 lines) Patch
A lib/i18n/date_format.dart View 1 2 1 chunk +161 lines, -0 lines 2 comments Download
A lib/i18n/message_format.dart View 1 1 chunk +86 lines, -0 lines 0 comments Download
A tests/lib/i18n/date_format_test.dart View 1 1 chunk +35 lines, -0 lines 0 comments Download
A tests/lib/i18n/message_format_test.dart View 1 2 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Emily Fortuna
Some of this is Alan's code (the date formatting) but we merged it into one ...
8 years, 6 months ago (2012-05-30 21:19:27 UTC) #1
Emily Fortuna
Just realized I forgot to fix package:. Doing that now. On 2012/05/30 21:19:27, Emily Fortuna ...
8 years, 6 months ago (2012-05-30 21:20:30 UTC) #2
Emily Fortuna
FYI: Talked to Bob -- package: won't work on the buildbots since they don't have ...
8 years, 6 months ago (2012-05-30 21:37:05 UTC) #3
Alan Knight
Mostly practicing making comments. https://chromiumcodereview.appspot.com/10453079/diff/3003/lib/i18n/date_format.dart File lib/i18n/date_format.dart (right): https://chromiumcodereview.appspot.com/10453079/diff/3003/lib/i18n/date_format.dart#newcode157 lib/i18n/date_format.dart:157: String format(Date date, [TimeZone timeZone]) ...
8 years, 6 months ago (2012-05-30 21:45:30 UTC) #4
Emily Fortuna
https://chromiumcodereview.appspot.com/10453079/diff/3003/lib/i18n/date_format.dart File lib/i18n/date_format.dart (right): https://chromiumcodereview.appspot.com/10453079/diff/3003/lib/i18n/date_format.dart#newcode157 lib/i18n/date_format.dart:157: String format(Date date, [TimeZone timeZone]) { On 2012/05/30 21:45:30, ...
8 years, 6 months ago (2012-05-30 22:18:07 UTC) #5
Jennifer Messerly
On 2012/05/30 22:18:07, Emily Fortuna wrote: > https://chromiumcodereview.appspot.com/10453079/diff/3003/lib/i18n/date_format.dart > File lib/i18n/date_format.dart (right): > > https://chromiumcodereview.appspot.com/10453079/diff/3003/lib/i18n/date_format.dart#newcode157 ...
8 years, 6 months ago (2012-05-30 22:26:02 UTC) #6
jacob314
8 years, 6 months ago (2012-05-30 22:26:33 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698