Issue 10452032: Merge functionality of HExactType into HBoundedType and fix computation of unions and intersections.

Issue 10452032: Merge functionality of HExactType into HBoundedType and fix computation of unions and intersections. (Closed)

Created:
8 years, 7 months ago by karlklose

Modified:
8 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Merge functionality of HExactType into HBoundedType and fix computation of unions and intersections. R=ngeoffray@google.com TEST=language/switch_this_test Committed: https://code.google.com/p/dart/source/detail?r=8057

Patch Set 1 #

Total comments: 7

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -49 lines)			Patch
M	frog/tests/leg/type_combination_test.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/ssa/types.dart	View	3 chunks	+48 lines, -36 lines	6 comments	Download
M	lib/compiler/implementation/ssa/types_propagation.dart	View	2 chunks	+4 lines, -2 lines	1 comment	Download
A	tests/language/switch_this_test.dart	View	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/10452032/diff/1/lib/compiler/implementation/ssa/types.dart File lib/compiler/implementation/ssa/types.dart (right): https://chromiumcodereview.appspot.com/10452032/diff/1/lib/compiler/implementation/ssa/types.dart#newcode601 lib/compiler/implementation/ssa/types.dart:601: final bool _isExact; I think I'd prefer having ...

8 years, 6 months ago (2012-05-29 12:16:21 UTC) #2

karlklose

8 years, 6 months ago (2012-05-29 13:25:15 UTC) #3

Thanks Nicolas.

https://chromiumcodereview.appspot.com/10452032/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/types.dart (right):

https://chromiumcodereview.appspot.com/10452032/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/types.dart:601: final bool _isExact;
The complicated code for the union/intersection was the reason to merge both
classes.

https://chromiumcodereview.appspot.com/10452032/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/types.dart:611: const HBoundedType(Type
this.type, bool this._canBeNull, this._isExact);
On 2012/05/29 12:16:21, ngeoffray wrote:
> Maybe use named arguments here and at the call site, to make it obvious what
> these sequences of [true, false] mean.

Done.

https://chromiumcodereview.appspot.com/10452032/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/types.dart:613: const
HBoundedType.canBeNull(Type type) : this(type, true, false);
On 2012/05/29 12:16:21, ngeoffray wrote:
> canBeNull -> withNull?

Done.

Expand Messages | Collapse Messages