Fix bug when a variable is used in try/catch and accessed trough HFieldGet and HFieldSet: reference…

Fix bug when a variable is used in try/catch and accessed trough HFieldGet and HFieldSet: reference a new HParameterValue instead of a name. Otherwise, the name may conflict with an existing variable.
Committed: https://code.google.com/p/dart/source/detail?r=7987

[kasperl, 2012-05-25 10:05:15]

LGTM. I'm not sure I'm super excited about the use of the word "activation", but
it's consistent with what's there already.

https://chromiumcodereview.appspot.com/10452029/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10452029/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:415: HParameterValue parameter =
builder.activationVariables.putIfAbsent(
This code should be refactored. There's a lot of duplication.

https://chromiumcodereview.appspot.com/10452029/diff/2001/tests/language/scop...
File tests/language/scoped_variables_try_catch_test.dart (right):

https://chromiumcodereview.appspot.com/10452029/diff/2001/tests/language/scop...
tests/language/scoped_variables_try_catch_test.dart:4: // Test that try/catch
does not shadow a variable at runtime.
I would add a newline before the test comment. It's hard to distinguish it from
the copyright notice.

[ngeoffray, 2012-05-25 10:45:10]

Thanks Kasper.

I have also changed the cl a bit to take into account a "real" parameter being
used indirectly. I will clean this up with the new liveness optimization.

https://chromiumcodereview.appspot.com/10452029/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10452029/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:415: HParameterValue parameter =
builder.activationVariables.putIfAbsent(
On 2012/05/25 10:05:15, kasperl wrote:
> This code should be refactored. There's a lot of duplication.

Done.

https://chromiumcodereview.appspot.com/10452029/diff/2001/tests/language/scop...
File tests/language/scoped_variables_try_catch_test.dart (right):

https://chromiumcodereview.appspot.com/10452029/diff/2001/tests/language/scop...
tests/language/scoped_variables_try_catch_test.dart:4: // Test that try/catch
does not shadow a variable at runtime.
On 2012/05/25 10:05:15, kasperl wrote:
> I would add a newline before the test comment. It's hard to distinguish it
from
> the copyright notice.

Done.