Issue 10451026: More intrinsification x64: array index load and store.

Issue 10451026: More intrinsification x64: array index load and store. (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More intrinsification x64: array index load and store. Committed: https://code.google.com/p/dart/source/detail?r=7970

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -1 line)			Patch
M	runtime/vm/assembler_x64.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1	1 chunk	+11 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	3 chunks	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with comments https://chromiumcodereview.appspot.com/10451026/diff/1/runtime/vm/assembler_x64_test.cc File runtime/vm/assembler_x64_test.cc (right): https://chromiumcodereview.appspot.com/10451026/diff/1/runtime/vm/assembler_x64_test.cc#newcode1220 runtime/vm/assembler_x64_test.cc:1220: __ addq(Address(RSP, 0), Immediate(-2)); You are ...

8 years, 7 months ago (2012-05-24 23:31:29 UTC) #2

srdjan

https://chromiumcodereview.appspot.com/10451026/diff/1/runtime/vm/assembler_x64_test.cc File runtime/vm/assembler_x64_test.cc (right): https://chromiumcodereview.appspot.com/10451026/diff/1/runtime/vm/assembler_x64_test.cc#newcode1220 runtime/vm/assembler_x64_test.cc:1220: __ addq(Address(RSP, 0), Immediate(-2)); On 2012/05/24 23:31:29, regis wrote: ...

8 years, 7 months ago (2012-05-24 23:54:13 UTC) #3

Expand Messages | Collapse Messages