Issue 10451006: - Rename NativeLoadField/NativeStoreField to LoadVMField/StoreVMField.

Issue 10451006: - Rename NativeLoadField/NativeStoreField to LoadVMField/StoreVMField. (Closed)

Created:
8 years, 7 months ago by Ivan Posva

Modified:
8 years, 6 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Rename NativeLoadField/NativeStoreField to LoadVMField/StoreVMField. - Implement code patterns for LoadVMField/StoreVMField. - Fix order of inputs in StoreVMField. Committed: https://code.google.com/p/dart/source/detail?r=7936

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -45 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	4 chunks	+6 lines, -6 lines	5 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+6 lines, -7 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	4 chunks	+19 lines, -19 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+16 lines, -8 lines	0 comments	Download
M	runtime/vm/locations.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://chromiumcodereview.appspot.com/10451006/diff/1008/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10451006/diff/1008/runtime/vm/flow_graph_builder.cc#newcode165 runtime/vm/flow_graph_builder.cc:165: Computation* store = new StoreVMFieldComp( return new StoreFieldComp( ...

8 years, 7 months ago (2012-05-24 01:15:47 UTC) #3

Florian Schneider

https://chromiumcodereview.appspot.com/10451006/diff/1008/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10451006/diff/1008/runtime/vm/flow_graph_builder.cc#newcode165 runtime/vm/flow_graph_builder.cc:165: Computation* store = new StoreVMFieldComp( On 2012/05/24 01:15:47, Florian ...

8 years, 7 months ago (2012-05-24 01:16:32 UTC) #4

Ivan Posva

8 years, 6 months ago (2012-05-29 17:35:03 UTC) #5

Will upload a new change for the suggested simplifications.

-Ivan

https://chromiumcodereview.appspot.com/10451006/diff/1008/runtime/vm/flow_gra...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10451006/diff/1008/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:165: Computation* store = new StoreVMFieldComp(
On 2012/05/24 01:16:32, Florian Schneider wrote:
> On 2012/05/24 01:15:47, Florian Schneider wrote:
> > return new StoreFieldComp(
> 
> I mean of course: 
> 
> return new StoreVMFieldComp(

Done.

https://chromiumcodereview.appspot.com/10451006/diff/1008/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:191: Computation* store = new LoadVMFieldComp(
On 2012/05/24 01:15:47, Florian Schneider wrote:
>   Computation* store = ...
> 
> does not make sense here. Maybe just rewrite to:
> 
>   return new LoadVMFieldComp(

Done.

Expand Messages | Collapse Messages