Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 10450020: - Bump the code heap size to avoid running out during testing. (Closed)

Created:
8 years, 7 months ago by Ivan Posva
Modified:
8 years, 7 months ago
Reviewers:
kasperl, siva, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Bump the code heap size to avoid running out during testing. Committed: https://code.google.com/p/dart/source/detail?r=7957

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M vm/heap.h View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
Quick fix to avoid build failures. Mid-term plan is to roll old-gen and code-heap into ...
8 years, 7 months ago (2012-05-24 18:11:07 UTC) #1
srdjan
https://chromiumcodereview.appspot.com/10450020/diff/1/vm/heap.h File vm/heap.h (right): https://chromiumcodereview.appspot.com/10450020/diff/1/vm/heap.h#newcode42 vm/heap.h:42: static const intptr_t kCodeHeapSizeInMB = 12; Since we generate ...
8 years, 7 months ago (2012-05-24 18:16:32 UTC) #2
siva
lgtm
8 years, 7 months ago (2012-05-24 20:02:30 UTC) #3
kasperl
8 years, 7 months ago (2012-05-25 04:28:11 UTC) #4
LGTM. Thanks, Ivan!

Powered by Google App Engine
This is Rietveld 408576698