Issue 10450006: Implement some intrinsics on x64, fix a bug in ia32 intrinciscs (must return false if there is a fa…

Issue 10450006: Implement some intrinsics on x64, fix a bug in ia32 intrinciscs (must return false if there is a fa… (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider, Vyacheslav Egorov (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement some intrinsics on x64, fix a bug in ia32 intrinciscs (must return false if there is a fall-through, so that slow path will be generated). Committed: https://code.google.com/p/dart/source/detail?r=7951

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -9 lines)			Patch
M	runtime/vm/assembler_x64.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/instructions_x64.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	7 chunks	+61 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10450006/diff/1/runtime/vm/intrinsifier_x64.cc File runtime/vm/intrinsifier_x64.cc (right): https://chromiumcodereview.appspot.com/10450006/diff/1/runtime/vm/intrinsifier_x64.cc#newcode57 runtime/vm/intrinsifier_x64.cc:57: bool Intrinsifier::GArray_Allocate(Assembler* assembler) { GrowableArray_Allocate? By looking at ...

8 years, 7 months ago (2012-05-24 15:47:32 UTC) #2

srdjan

8 years, 7 months ago (2012-05-24 15:51:04 UTC) #3

https://chromiumcodereview.appspot.com/10450006/diff/1/runtime/vm/intrinsifie...
File runtime/vm/intrinsifier_x64.cc (right):

https://chromiumcodereview.appspot.com/10450006/diff/1/runtime/vm/intrinsifie...
runtime/vm/intrinsifier_x64.cc:57: bool Intrinsifier::GArray_Allocate(Assembler*
assembler) {
On 2012/05/24 15:47:32, regis wrote:
> GrowableArray_Allocate?
> By looking at the header, I see why this is not a typo :-)
> I could live with a broken up line in the header.

For another CL. (renaming intrinsics touches several additional files).

https://chromiumcodereview.appspot.com/10450006/diff/1/runtime/vm/intrinsifie...
runtime/vm/intrinsifier_x64.cc:266: __ nop(JumpPattern::InstructionLength() -
offset);
On 2012/05/24 15:47:32, regis wrote:
> Do we check for minimum code size when finalizing the code? That would be
good.

Yes, we do (was hitting an assert here).

Expand Messages | Collapse Messages