Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 10449091: Removed asyncTest and improved comments. (Closed)

Created:
8 years, 6 months ago by gram
Modified:
8 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removed asyncTest and improved comments. Committed: https://code.google.com/p/dart/source/detail?r=8170

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -62 lines) Patch
M lib/unittest/unittest.dart View 1 8 chunks +26 lines, -28 lines 0 comments Download
M tests/html/fileapi_test.dart View 1 1 chunk +22 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gram
8 years, 6 months ago (2012-05-31 17:05:39 UTC) #1
Emily Fortuna
lgtm, but please address comments first. http://codereview.chromium.org/10449091/diff/1/lib/unittest/unittest.dart File lib/unittest/unittest.dart (right): http://codereview.chromium.org/10449091/diff/1/lib/unittest/unittest.dart#newcode73 lib/unittest/unittest.dart:73: * depending on ...
8 years, 6 months ago (2012-05-31 17:09:28 UTC) #2
gram
PTAL, thanks! http://codereview.chromium.org/10449091/diff/1/lib/unittest/unittest.dart File lib/unittest/unittest.dart (right): http://codereview.chromium.org/10449091/diff/1/lib/unittest/unittest.dart#newcode73 lib/unittest/unittest.dart:73: * depending on the suffix of expectAsyncX(). ...
8 years, 6 months ago (2012-05-31 17:38:42 UTC) #3
Emily Fortuna
8 years, 6 months ago (2012-05-31 17:41:15 UTC) #4
lgtm!

Powered by Google App Engine
This is Rietveld 408576698