Issue 10448075: Fix indexeddb_4_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10448075: Fix indexeddb_4_test. (Closed)

Created:
8 years, 6 months ago by podivilov

Modified:
8 years, 6 months ago

Reviewers:
vsm, Anton Muhin, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix indexeddb_4_test. R=sra@google.com,vsm@google.com,antonm@google.com BUG=3301 Committed: https://code.google.com/p/dart/source/detail?r=8185

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -10 lines)			Patch
M	tests/html/html.status	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/html/indexeddb_3_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/indexeddb_4_test.dart	View	3 chunks	+5 lines, -6 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm http://codereview.chromium.org/10448075/diff/1/tests/html/indexeddb_4_test.dart File tests/html/indexeddb_4_test.dart (right): http://codereview.chromium.org/10448075/diff/1/tests/html/indexeddb_4_test.dart#newcode74 tests/html/indexeddb_4_test.dart:74: Expect.equals('Item ${cursor.key.toStringAsFixed(0)}', cursor.value); It still bothers me a ...

8 years, 6 months ago (2012-05-31 15:34:38 UTC) #3

podivilov

8 years, 6 months ago (2012-05-31 17:08:24 UTC) #4

http://codereview.chromium.org/10448075/diff/1/tests/html/indexeddb_4_test.dart
File tests/html/indexeddb_4_test.dart (right):

http://codereview.chromium.org/10448075/diff/1/tests/html/indexeddb_4_test.da...
tests/html/indexeddb_4_test.dart:74: Expect.equals('Item
${cursor.key.toStringAsFixed(0)}', cursor.value);
Filed a bug: http://code.google.com/p/dart/issues/detail?id=3330.

Expand Messages | Collapse Messages