Canonicalize bound closures for non-optional-arg methods.

Canonicalize bound closures for non-optional-arg methods.

Committed: https://code.google.com/p/dart/source/detail?r=8102

[floitsch, 2012-05-25 14:17:21]

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
File lib/compiler/implementation/emitter.dart (left):

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:670: String targetName =
namer.instanceMethodName(member.getLibrary(),
This line has been moved down.

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:696: closureClass =
namer.isolateAccess(closureClassElement);
Starting at 696 we have lines that weren't in the previous revision. Otherwise
the code just has been indented.

[kasperl, 2012-05-30 08:15:51]

LGTM!

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:633: // 'foo'. Then we generate the
following code (in pseudo Dart/Js):
Js -> JavaScript

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:651: member.parameterCount(compiler);
This looks fishy.

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:653: String closureClass = null;
Maybe use something ala:

   String closureClass = hasOptionalParameters
       ? null
       : boundClosureCache[parameterCount];

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:684: arguments[i] = "arg$i";
I wonder if a shorter name wouldn't be as nice. p0, p1?

[ngeoffray, 2012-05-30 10:23:32]

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:647: // if there are no optional
parameters.
Explain why.

[floitsch, 2012-05-30 13:24:07]

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:633: // 'foo'. Then we generate the
following code (in pseudo Dart/Js):
On 2012/05/30 08:15:51, kasperl wrote:
> Js -> JavaScript

Done.

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:647: // if there are no optional
parameters.
On 2012/05/30 10:23:33, ngeoffray wrote:
> Explain why.

Done.

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:651: member.parameterCount(compiler);
On 2012/05/30 08:15:51, kasperl wrote:
> This looks fishy.
removed.

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:653: String closureClass = null;
On 2012/05/30 08:15:51, kasperl wrote:
> Maybe use something ala:
> 
>    String closureClass = hasOptionalParameters
>        ? null
>        : boundClosureCache[parameterCount];

Done.

https://chromiumcodereview.appspot.com/10448025/diff/1/lib/compiler/implement...
lib/compiler/implementation/emitter.dart:684: arguments[i] = "arg$i";
On 2012/05/30 08:15:51, kasperl wrote:
> I wonder if a shorter name wouldn't be as nice. p0, p1?

Done.