Apply html renames to native wrappers.

Apply html renames to native wrappers.


R=antonm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=7992

[Anton Muhin, 2012-05-24 17:16:58]

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:261: 'IFrameElement.get:contentWindow',
why this move?

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:573: for ancestor_name in
self._AllAncestorInterfaces(interface_name):
it looks like now you can merge this logic into _Matches, correct?

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:585: target_name = '$dom_' + target_name
this works by a chance as you don't account for member_prefix?

[podivilov, 2012-05-25 12:00:35]

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:261: 'IFrameElement.get:contentWindow',
On 2012/05/24 17:16:58, antonmuhin wrote:
> why this move?

contentWindow is not removed from dart:html, it just has custom implementation.

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:573: for ancestor_name in
self._AllAncestorInterfaces(interface_name):
On 2012/05/24 17:16:58, antonmuhin wrote:
> it looks like now you can merge this logic into _Matches, correct?

Could you please clarify? I don't see how it can be done...

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:585: target_name = '$dom_' + target_name
On 2012/05/24 17:16:58, antonmuhin wrote:
> this works by a chance as you don't account for member_prefix?

member_prefix is passed to self._Matches above. Am I missing something?

[Anton Muhin, 2012-05-25 12:04:29]

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:573: for ancestor_name in
self._AllAncestorInterfaces(interface_name):
Sorry.

It looks like the loop below is almost _Matches method above.  The only
difference is _Mathces returns bool, while this loop looks for new name.

So if _Matches could return a string iff there is a match or None, you would be
able to use it right here.

On 2012/05/25 12:00:35, podivilov wrote:
> On 2012/05/24 17:16:58, antonmuhin wrote:
> > it looks like now you can merge this logic into _Matches, correct?
> 
> Could you please clarify? I don't see how it can be done...

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:585: target_name = '$dom_' + target_name
Yes, sorry, I was wrong.

On 2012/05/25 12:00:35, podivilov wrote:
> On 2012/05/24 17:16:58, antonmuhin wrote:
> > this works by a chance as you don't account for member_prefix?
> 
> member_prefix is passed to self._Matches above. Am I missing something?

[podivilov, 2012-05-25 12:16:27]

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:573: for ancestor_name in
self._AllAncestorInterfaces(interface_name):
_Matches works with sets, while _html_library_renames is a map. Still it could
be merged, but I'm not sure if it worth doing.

[Anton Muhin, 2012-05-25 12:17:44]

lgtm

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10448009/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:573: for ancestor_name in
self._AllAncestorInterfaces(interface_name):
I think it's worth it, but up to you.

On 2012/05/25 12:16:32, podivilov wrote:
> _Matches works with sets, while _html_library_renames is a map. Still it could
> be merged, but I'm not sure if it worth doing.

[podivilov, 2012-05-25 12:37:53]

http://codereview.chromium.org/10448009/diff/1/lib/dom/scripts/systemhtml.py
File lib/dom/scripts/systemhtml.py (right):

http://codereview.chromium.org/10448009/diff/1/lib/dom/scripts/systemhtml.py#...
lib/dom/scripts/systemhtml.py:573: for ancestor_name in
self._AllAncestorInterfaces(interface_name):
On 2012/05/25 12:17:45, antonmuhin wrote:
> I think it's worth it, but up to you.
> 
> On 2012/05/25 12:16:32, podivilov wrote:
> > _Matches works with sets, while _html_library_renames is a map. Still it
could
> > be merged, but I'm not sure if it worth doing.
> 

Done.

[Anton Muhin, 2012-05-25 12:39:16]

http://codereview.chromium.org/10448009/diff/1/lib/dom/scripts/systemhtml.py
File lib/dom/scripts/systemhtml.py (right):

http://codereview.chromium.org/10448009/diff/1/lib/dom/scripts/systemhtml.py#...
lib/dom/scripts/systemhtml.py:573: for ancestor_name in
self._AllAncestorInterfaces(interface_name):
Thanks a lot!  Still LGTM

On 2012/05/25 12:37:54, podivilov wrote:
> On 2012/05/25 12:17:45, antonmuhin wrote:
> > I think it's worth it, but up to you.
> > 
> > On 2012/05/25 12:16:32, podivilov wrote:
> > > _Matches works with sets, while _html_library_renames is a map. Still it
> could
> > > be merged, but I'm not sure if it worth doing.
> > 
> 
> Done.