Issue 10447064: In generated code for ia32 don't load object's class directly from class_ field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10447064: In generated code for ia32 don't load object's class directly from class_ field. (Closed)

Created:
8 years, 6 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

In generated code for ia32 don't load object's class directly from class_ field. Instead look it up in class table by class index taken from object's tags. Committed: https://code.google.com/p/dart/source/detail?r=8101

Patch Set 1 #

Total comments: 3

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+113 lines, -68 lines)			Patch
M	runtime/vm/assembler_ia32.h	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	runtime/vm/class_table.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	8 chunks	+26 lines, -26 lines	1 comment	Download
M	runtime/vm/intrinsifier_ia32.cc	View	4 chunks	+10 lines, -12 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	12 chunks	+18 lines, -22 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	7 chunks	+9 lines, -8 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

Hi Ivan, This is the first CL separated from https://chromiumcodereview.appspot.com/10450014/ It converts all loads of ...

8 years, 6 months ago (2012-05-29 13:12:39 UTC) #1

Ivan Posva

8 years, 6 months ago (2012-05-30 05:48:09 UTC) #2

LGTM with comments.

-Ivan

https://chromiumcodereview.appspot.com/10447064/diff/1/runtime/vm/code_genera...
File runtime/vm/code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/10447064/diff/1/runtime/vm/code_genera...
runtime/vm/code_generator_ia32.cc:1575: const Class& mint_class =
Class::ZoneHandle(
ZoneHandle no longer needed, a Handle should be enough.

ditto in many other places.

https://chromiumcodereview.appspot.com/10447064/diff/1/runtime/vm/stub_code_i...
File runtime/vm/stub_code_ia32.cc (right):

https://chromiumcodereview.appspot.com/10447064/diff/1/runtime/vm/stub_code_i...
runtime/vm/stub_code_ia32.cc:1594: // EAX: receiver's class.
This comment is out of date.

https://chromiumcodereview.appspot.com/10447064/diff/1/runtime/vm/stub_code_i...
runtime/vm/stub_code_ia32.cc:1620: // TODO(vegorov): switch IC data to store
class index insted of class.
instead

In general I think resolving this TODO is one of the next major steps.

Expand Messages | Collapse Messages