Issue 10447060: Handle native paths in test wrappers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10447060: Handle native paths in test wrappers. (Closed)

Created:
8 years, 6 months ago by ahe

Modified:
8 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handle native paths in test wrappers. Committed: https://code.google.com/p/dart/source/detail?r=8041

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
	M	dart/tools/testing/dart/browser_test.dart	View	1	2 chunks	+21 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

STV! https://chromiumcodereview.appspot.com/10447060/diff/1/dart/tools/testing/dart/browser_test.dart File dart/tools/testing/dart/browser_test.dart (right): https://chromiumcodereview.appspot.com/10447060/diff/1/dart/tools/testing/dart/browser_test.dart#newcode55 dart/tools/testing/dart/browser_test.dart:55: final re = const RegExp('^[a-z]:', ignoreCase: true); Please ...

8 years, 6 months ago (2012-05-29 09:03:18 UTC) #2

ahe

8 years, 6 months ago (2012-05-29 09:15:10 UTC) #3

Thank you, Nicolas!

https://chromiumcodereview.appspot.com/10447060/diff/1/dart/tools/testing/dar...
File dart/tools/testing/dart/browser_test.dart (right):

https://chromiumcodereview.appspot.com/10447060/diff/1/dart/tools/testing/dar...
dart/tools/testing/dart/browser_test.dart:55: final re = const RegExp('^[a-z]:',
ignoreCase: true);
On 2012/05/29 09:03:18, ngeoffray wrote:
> Please add a comment on what this regexp is for.

Done.

Expand Messages | Collapse Messages

Issue 10447060: Handle native paths in test wrappers. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages