Issue 10446112: Refactor snapshot writing code in preparation for the change to remove recursive calls to WriteObje…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10446112: Refactor snapshot writing code in preparation for the change to remove recursive calls to WriteObje… (Closed)

Created:
8 years, 6 months ago by siva

Modified:
8 years, 6 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Refactor snapshot writing code in preparation for the change to remove recursive calls to WriteObject and ReadObject. Committed: https://code.google.com/p/dart/source/detail?r=8181

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -523 lines)			Patch
M	vm/raw_object_snapshot.cc	View	1	2 chunks	+63 lines, -451 lines	0 comments	Download
M	vm/snapshot.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	vm/snapshot.cc	View	1	3 chunks	+79 lines, -71 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cshapiro

lgtm http://codereview.chromium.org/10446112/diff/1/vm/raw_object_snapshot.cc File vm/raw_object_snapshot.cc (right): http://codereview.chromium.org/10446112/diff/1/vm/raw_object_snapshot.cc#newcode1822 vm/raw_object_snapshot.cc:1822: #define TYPE_LIST(V) \ Could be BYTE_ARRAY_TYPE_LIST to avoid ...

8 years, 6 months ago (2012-05-31 23:53:19 UTC) #2

siva

8 years, 6 months ago (2012-06-01 00:12:50 UTC) #3

http://codereview.chromium.org/10446112/diff/1/vm/raw_object_snapshot.cc
File vm/raw_object_snapshot.cc (right):

http://codereview.chromium.org/10446112/diff/1/vm/raw_object_snapshot.cc#newc...
vm/raw_object_snapshot.cc:1822: #define TYPE_LIST(V)                            
                              \
On 2012/05/31 23:53:19, cshapiro wrote:
> Could be BYTE_ARRAY_TYPE_LIST to avoid potential namespace collisions

Done.

Expand Messages | Collapse Messages

Issue 10446112: Refactor snapshot writing code in preparation for the change to remove recursive calls to WriteObje… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages