Issue 10446102: Insert closure calls in conditional expression of assert (issue 1584).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10446102: Insert closure calls in conditional expression of assert (issue 1584). (Closed)

Created:
8 years, 6 months ago by regis

Modified:
8 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Insert closure calls in conditional expression of assert (issue 1584). Committed: https://code.google.com/p/dart/source/detail?r=8164

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -9 lines)			Patch
M	runtime/vm/ast.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	2 chunks	+18 lines, -8 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with question https://chromiumcodereview.appspot.com/10446102/diff/1/runtime/vm/ast.h File runtime/vm/ast.h (right): https://chromiumcodereview.appspot.com/10446102/diff/1/runtime/vm/ast.h#newcode662 runtime/vm/ast.h:662: ASSERT(true_expr_ != NULL); Why are these ...

8 years, 6 months ago (2012-05-31 15:39:11 UTC) #2

regis

8 years, 6 months ago (2012-05-31 15:56:24 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10446102/diff/1/runtime/vm/ast.h
File runtime/vm/ast.h (right):

https://chromiumcodereview.appspot.com/10446102/diff/1/runtime/vm/ast.h#newco...
runtime/vm/ast.h:662: ASSERT(true_expr_ != NULL);
On 2012/05/31 15:39:11, srdjan wrote:
> Why are these asserts necessary? Dop you want to check that true_expr != NULL
> instead (also below)

Yes, of course. Copy and paste error. Thanks!

Expand Messages | Collapse Messages

Issue 10446102: Insert closure calls in conditional expression of assert (issue 1584). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages