Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 10446055: Update the script that we run on the buildbot to test dart2js rather than frog across the different… (Closed)

Created:
8 years, 6 months ago by kasperl
Modified:
8 years, 6 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update the script that we run on the buildbot to test dart2js rather than frog across the different browsers. R=ngeoffray@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8032

Patch Set 1 #

Total comments: 1

Patch Set 2 : Simpler cleanup check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -29 lines) Patch
M utils/compiler/buildbot.py View 1 5 chunks +18 lines, -29 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kasperl
8 years, 6 months ago (2012-05-29 07:09:46 UTC) #1
ngeoffray
8 years, 6 months ago (2012-05-29 07:13:06 UTC) #2
LGTM!

https://chromiumcodereview.appspot.com/10446055/diff/1/utils/compiler/buildbo...
File utils/compiler/buildbot.py (right):

https://chromiumcodereview.appspot.com/10446055/diff/1/utils/compiler/buildbo...
utils/compiler/buildbot.py:174: def TestCompiler(compiler, runtime, mode,
system, option, flags, bot_number=None):
line too long

Powered by Google App Engine
This is Rietveld 408576698