Issue 10445011: Events operator [] shouldn't convert event name to lower case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10445011: Events operator [] shouldn't convert event name to lower case. (Closed)

Created:
8 years, 7 months ago by podivilov

Modified:
8 years, 6 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Events operator [] shouldn't convert event name to lower case. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=9154

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+337 lines, -345 lines)			Patch
M	lib/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/templates/html/dartium/impl_EventTarget.darttemplate	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	lib/dom/templates/html/frog/impl_EventTarget.darttemplate	View	1 chunk	+1 line, -3 lines	1 comment	Download
M	lib/html/frog/html_frog.dart	View	37 chunks	+335 lines, -337 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm http://codereview.chromium.org/10445011/diff/1/lib/dom/templates/html/frog/impl_EventTarget.darttemplate File lib/dom/templates/html/frog/impl_EventTarget.darttemplate (right): http://codereview.chromium.org/10445011/diff/1/lib/dom/templates/html/frog/impl_EventTarget.darttemplate#newcode13 lib/dom/templates/html/frog/impl_EventTarget.darttemplate:13: _EventListenerListImpl operator [](String type) { => syntax?

8 years, 6 months ago (2012-06-05 13:47:02 UTC) #2

has it been submitted?  why it's still open?

Expand Messages | Collapse Messages