Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 10444138: Implement super store. (Closed)

Created:
8 years, 6 months ago by ahe
Modified:
8 years, 6 months ago
Reviewers:
ngeoffray, kasperl
CC:
reviews_dartlang.org, dgrove, floitsch, karlklose
Visibility:
Public.

Description

Implement super store. Committed: https://code.google.com/p/dart/source/detail?r=8201

Patch Set 1 : #

Patch Set 2 : Update test status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -24 lines) Patch
M dart/lib/compiler/implementation/ssa/builder.dart View 2 chunks +28 lines, -19 lines 0 comments Download
M dart/lib/compiler/implementation/ssa/codegen.dart View 1 chunk +10 lines, -3 lines 0 comments Download
M dart/tests/co19/co19-leg.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
I'm testing right now. I hope some existing tests will start passing, otherwise I'll add ...
8 years, 6 months ago (2012-06-01 14:06:21 UTC) #1
ngeoffray
LGTM
8 years, 6 months ago (2012-06-01 14:09:55 UTC) #2
ahe
8 years, 6 months ago (2012-06-01 16:11:56 UTC) #3
Thank you, Nicolas!

Updated with test status.

Cheers,
Peter

Powered by Google App Engine
This is Rietveld 408576698