Issue 10444016: Re-enable Yaml tests on dart2js and dartc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10444016: Re-enable Yaml tests on dart2js and dartc. (Closed)

Created:
8 years, 7 months ago by nweiz

Modified:
8 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-enable Yaml tests on dart2js and dartc. Also fix a couple warnings in dart2js. Committed: https://code.google.com/p/dart/source/detail?r=7966

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -6 lines)			Patch
	M	utils/pub/yaml/parser.dart	View		3 chunks	+3 lines, -0 lines	1 comment	Download
	M	utils/tests/pub/pub.status	View		1 chunk	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

8 years, 7 months ago (2012-05-24 22:36:50 UTC) #2

LGTM!

https://chromiumcodereview.appspot.com/10444016/diff/1/utils/pub/yaml/parser....
File utils/pub/yaml/parser.dart (right):

https://chromiumcodereview.appspot.com/10444016/diff/1/utils/pub/yaml/parser....
utils/pub/yaml/parser.dart:251: return null; // unreachable
"Unreachable."

Expand Messages | Collapse Messages