Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 10444004: Cleanup systemhtml name lists so we can reuse them for generating wrapperless dart:html for Dartium. (Closed)

Created:
8 years, 7 months ago by podivilov
Modified:
8 years, 7 months ago
Reviewers:
jacob314, sra1, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleanup systemhtml name lists so we can reuse them for generating wrapperless dart:html for Dartium. R=jacobr@google.com,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=7981

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -36 lines) Patch
M lib/dom/scripts/systemhtml.py View 11 chunks +37 lines, -32 lines 5 comments Download
M lib/html/dartium/html_dartium.dart View 9 chunks +36 lines, -2 lines 1 comment Download
M lib/html/frog/html_frog.dart View 9 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
podivilov
8 years, 7 months ago (2012-05-24 08:22:33 UTC) #1
podivilov
http://codereview.chromium.org/10444004/diff/1/lib/dom/scripts/systemhtml.py File lib/dom/scripts/systemhtml.py (left): http://codereview.chromium.org/10444004/diff/1/lib/dom/scripts/systemhtml.py#oldcode77 lib/dom/scripts/systemhtml.py:77: 'Document.querySelectorAll', This one is in _private_html_members list already. http://codereview.chromium.org/10444004/diff/1/lib/dom/scripts/systemhtml.py#oldcode78 ...
8 years, 7 months ago (2012-05-24 08:29:04 UTC) #2
jacob314
8 years, 7 months ago (2012-05-24 17:56:02 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698