Issue 10443122: Revert "Revert "Rework Element constructors""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10443122: Revert "Revert "Rework Element constructors"" (Closed)

Created:
8 years, 6 months ago by sra1

Modified:
8 years, 6 months ago

Reviewers:
vsm, Anton Muhin, podivilov1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "Rework Element constructors"" This CL is r8182 plus some other bug fixes to get to green. The main change is that the first parent of an interface could be a pure interface. In that case, it should be treated as a secondary parent interface, not as the primary implementation inheritance parent. Committed: https://code.google.com/p/dart/source/detail?r=8184

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+869 lines, -883 lines)			Patch
M	lib/dom/dom.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View	14 chunks	+15 lines, -127 lines	0 comments	Download
M	lib/dom/scripts/dartgenerator.py	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	lib/dom/scripts/generator.py	View	5 chunks	+11 lines, -0 lines	0 comments	Download
M	lib/dom/scripts/systemfrog.py	View	4 chunks	+9 lines, -0 lines	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View	14 chunks	+92 lines, -55 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View	6 chunks	+28 lines, -0 lines	0 comments	Download
A +	lib/dom/templates/html/dartium/factoryprovider__Elements.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download
A +	lib/dom/templates/html/frog/factoryprovider__Elements.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	lib/dom/templates/html/interface/factoryprovider__Elements.darttemplate	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	9 chunks	+383 lines, -301 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View	18 chunks	+317 lines, -389 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sra1

8 years, 6 months ago (2012-06-01 07:28:13 UTC) #1

Hi guys,

There is a lot that got broken with the html libraries.
I hope this gets us to a checked in set of libraries that works.

I'd appreciate it if we can get this to settle before checking in any other
changes.

Expand Messages | Collapse Messages