Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 10443067: Add a regression test for bug 2235. (Closed)

Created:
8 years, 6 months ago by turnidge
Modified:
8 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add a regression test for bug 2235. Committed: https://code.google.com/p/dart/source/detail?r=8081

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M tests/isolate/isolate.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/isolate/v2_spawn_function_custom_class_test.dart View 1 chunk +38 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
TBR=iposva
8 years, 6 months ago (2012-05-29 21:36:26 UTC) #1
Ivan Posva
The change LGTM as it mimics the other isolate tests. Adding Siggi as it bothers ...
8 years, 6 months ago (2012-05-29 21:55:58 UTC) #2
Siggi Cherem (dart-lang)
8 years, 6 months ago (2012-06-05 21:49:50 UTC) #3
https://chromiumcodereview.appspot.com/10443067/diff/1/tests/isolate/v2_spawn...
File tests/isolate/v2_spawn_function_custom_class_test.dart (right):

https://chromiumcodereview.appspot.com/10443067/diff/1/tests/isolate/v2_spawn...
tests/isolate/v2_spawn_function_custom_class_test.dart:28: test('message - reply
chain', () {
On 2012/05/29 21:55:58, Ivan Posva wrote:
> What bothers me here is that we are in a circular dependency. The test
framework
> itself depends on isolates to be working properly and it is used to test
> isolates. Siggi, any suggestion to address this?

It bothers me too.

The only reason we use dart:isolate in the unittest library is that we basically
need a platform independent way to run code at the end of the event loop. We use
messages within the same isolate to achieve this. That means that we are not
depending on 'spawn' for the unittest library, but we use port send/receive.
That's also why I didn't convert port_tests to use unittest.dart.

If we can provide a way to get a platform independent 'defer' in some 'dart:'
library, we could get rid of this dependence. Note, this platform independent
'defer' is needed also to fix some bugs in the 'future' code.

Powered by Google App Engine
This is Rietveld 408576698