Issue 10443032: Generate default constructors instead of factories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10443032: Generate default constructors instead of factories. (Closed)

Created:
8 years, 7 months ago by podivilov

Modified:
8 years, 6 months ago

Reviewers:
vsm, Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Generate default constructors instead of factories. This is needed to instantiate wrappers using Dart_New. See http://codereview.chromium.org/10453030/. R=antonm@google.com,vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=8027

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
	M	lib/dom/src/native_DOMImplementation.dart	View		2 chunks	+7 lines, -9 lines	2 comments	Download
	M	lib/dom/templates/dom/native/dart_implementation.darttemplate	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://chromiumcodereview.appspot.com/10443032/diff/1/lib/dom/src/native_DOMImplementation.dart File lib/dom/src/native_DOMImplementation.dart (right): https://chromiumcodereview.appspot.com/10443032/diff/1/lib/dom/src/native_DOMImplementation.dart#newcode41 lib/dom/src/native_DOMImplementation.dart:41: _NPObject() {} here and everywhere: $CLASS(); (w/ no ...

8 years, 6 months ago (2012-05-28 05:52:28 UTC) #3

podivilov

8 years, 6 months ago (2012-05-28 09:52:35 UTC) #4

http://codereview.chromium.org/10443032/diff/1/lib/dom/src/native_DOMImplemen...
File lib/dom/src/native_DOMImplementation.dart (right):

http://codereview.chromium.org/10443032/diff/1/lib/dom/src/native_DOMImplemen...
lib/dom/src/native_DOMImplementation.dart:41: _NPObject() {}
On 2012/05/28 05:52:28, antonmuhin wrote:
> here and everywhere: $CLASS(); (w/ no {}, just ;) is more idiomatic Dart imho.

Done.

Expand Messages | Collapse Messages