Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 10443029: Use Dart_New to construct OSError objects instead of the static (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)
Modified:
8 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use Dart_New to construct OSError objects instead of the static method workaround. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M runtime/bin/common.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 7 months ago (2012-05-25 12:25:07 UTC) #1
Søren Gjesse
8 years, 7 months ago (2012-05-25 12:47:55 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698