Issue 10443013: Add support for temp locations and port Load-/StoreStaticField to use locations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10443013: Add support for temp locations and port Load-/StoreStaticField to use locations. (Closed)

Created:
8 years, 7 months ago by Florian Schneider

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add support for temp locations and port Load-/StoreStaticField to use locations. The temps are allocated like inputs (can be fixed register or not). Temp registers are always distinct from all inputs and the output. Committed: https://code.google.com/p/dart/source/detail?r=7961

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -20 lines)			Patch
M	vm/flow_graph_compiler_x64.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	vm/intermediate_language_x64.cc	View	1	4 chunks	+18 lines, -7 lines	0 comments	Download
M	vm/locations.h	View		3 chunks	+22 lines, -4 lines	0 comments	Download
M	vm/locations.cc	View		4 chunks	+26 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

srdjan

8 years, 7 months ago (2012-05-24 18:57:13 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10443013/diff/4001/vm/locations.cc
File vm/locations.cc (right):

https://chromiumcodereview.appspot.com/10443013/diff/4001/vm/locations.cc#new...
vm/locations.cc:52: blocked_registers[out().reg()] = true;
We should be able to have the same input/temp and output register, i.e., the
assert maybe wrong.

Expand Messages | Collapse Messages