Implement File.lastModified.

Implement File.lastModified.

R=sgjesse@google.com,ajohnsen@google.com
BUG=dartbug/2988
TEST=standalone/io/file*

Committed: https://code.google.com/p/dart/source/detail?r=7945

[Anders Johnsen, 2012-05-24 12:05:42]

LGTM, thank you! :)

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file.h
File runtime/bin/file.h (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file.h#new...
runtime/bin/file.h:129: static time_t LastModified(const char* name);
I guess this should return an intptr_t?

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:5: final int _MS_PER_SECOND = 1000;
Could this be renamed to _kMsPerSecond? Also, would it be possible to put it
into one of the objects, e.g. FileBase::_kMsPerSecond?

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_linux.cc
File runtime/bin/file_linux.cc (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_linux...
runtime/bin/file_linux.cc:177: time_t File::LastModified(const char* name) {
intprt_t

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_macos.cc
File runtime/bin/file_macos.cc (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_macos...
runtime/bin/file_macos.cc:178: time_t File::LastModified(const char* name) {
intptr_t

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_win.cc
File runtime/bin/file_win.cc (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_win.c...
runtime/bin/file_win.cc:166: time_t File::LastModified(const char* name) {
intptr_t

https://chromiumcodereview.appspot.com/10443008/diff/1/tests/standalone/io/fi...
File tests/standalone/io/file_test.dart (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/tests/standalone/io/fi...
tests/standalone/io/file_test.dart:976: new File(new
Options().executable).lastModified().then((modified) {
Cute :)

[Mads Ager (google), 2012-05-24 12:09:21]

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file.h
File runtime/bin/file.h (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file.h#new...
runtime/bin/file.h:129: static time_t LastModified(const char* name);
On 2012/05/24 12:05:42, ajohnsen wrote:
> I guess this should return an intptr_t?

I'm keeping it consistent with Length which returns the actual type the OS gives
you which is off_t for length and time_t for last modified.

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:5: final int _MS_PER_SECOND = 1000;
On 2012/05/24 12:05:42, ajohnsen wrote:
> Could this be renamed to _kMsPerSecond? Also, would it be possible to put it
> into one of the objects, e.g. FileBase::_kMsPerSecond?

No, that is not the style we have for constants in Dart code. It is our style
for constants in C++.

[Anders Johnsen, 2012-05-24 12:12:59]

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file.h
File runtime/bin/file.h (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file.h#new...
runtime/bin/file.h:129: static time_t LastModified(const char* name);
On 2012/05/24 12:09:21, Mads Ager wrote:
> On 2012/05/24 12:05:42, ajohnsen wrote:
> > I guess this should return an intptr_t?
> 
> I'm keeping it consistent with Length which returns the actual type the OS
gives
> you which is off_t for length and time_t for last modified.

Okay.

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:5: final int _MS_PER_SECOND = 1000;
On 2012/05/24 12:09:21, Mads Ager wrote:
> On 2012/05/24 12:05:42, ajohnsen wrote:
> > Could this be renamed to _kMsPerSecond? Also, would it be possible to put it
> > into one of the objects, e.g. FileBase::_kMsPerSecond?
> 
> No, that is not the style we have for constants in Dart code. It is our style
> for constants in C++.

I stand corrected. We do have a ton of k... constants in this file though.

[Mads Ager (google), 2012-05-24 12:18:43]

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:5: final int _MS_PER_SECOND = 1000;
On 2012/05/24 12:12:59, ajohnsen wrote:
> On 2012/05/24 12:09:21, Mads Ager wrote:
> > On 2012/05/24 12:05:42, ajohnsen wrote:
> > > Could this be renamed to _kMsPerSecond? Also, would it be possible to put
it
> > > into one of the objects, e.g. FileBase::_kMsPerSecond?
> > 
> > No, that is not the style we have for constants in Dart code. It is our
style
> > for constants in C++.
> 
> I stand corrected. We do have a ton of k... constants in this file though.

That is true. We should update those. I do prefer kName for constants myself so
this will be painful. ;-)

[Søren Gjesse, 2012-05-24 12:43:45]

lgtm

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:534: return new Date.fromEpoch(response *
_MS_PER_SECOND);
How about having the result be in ms so we don't have the * _MS_PER_SECOND here
but in the OS files instead. Then we could change to use a more precise system
call (if it exists) with less changes to the code.

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:540: return new Date.fromEpoch(result *
_MS_PER_SECOND);
Ditto.

[Mads Ager (google), 2012-05-24 13:09:40]

Updated lots of constants to the Dart code style. Returning ms from C.

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10443008/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:534: return new Date.fromEpoch(response *
_MS_PER_SECOND);
On 2012/05/24 12:43:45, Søren Gjesse wrote:
> How about having the result be in ms so we don't have the * _MS_PER_SECOND
here
> but in the OS files instead. Then we could change to use a more precise system
> call (if it exists) with less changes to the code.

Good call. That makes sense. Will do.