Issue 10442125: Rework Element constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10442125: Rework Element constructors (Closed)

Created:
8 years, 6 months ago by sra1

Modified:
8 years, 6 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rework Element constructors It turns out we want different types in the frog vs dartium bodies. We want the implementation type for frog to help with live type analysis. We can't use the only slightly less general interface type because the language mandates a warning. So we now generate the factory constructors for each implementation system rather than once for the interfaces system. I also extended the mechanism to handle multiple element constructors and used it to generate HeadingElement.h1() through HeadingElement.h6() Committed: https://code.google.com/p/dart/source/detail?r=8182

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review and rebase #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1008 lines, -802 lines)			Patch
M	lib/dom/dom.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	lib/dom/scripts/generator.py	View		4 chunks	+10 lines, -0 lines	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View	1	12 chunks	+88 lines, -55 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View		5 chunks	+25 lines, -0 lines	0 comments	Download
A +	lib/dom/templates/html/dartium/factoryprovider__Elements.darttemplate	View		1 chunk	+0 lines, -1 line	0 comments	Download
A +	lib/dom/templates/html/frog/factoryprovider__Elements.darttemplate	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	lib/dom/templates/html/interface/factoryprovider__Elements.darttemplate	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		9 chunks	+379 lines, -301 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View		6 chunks	+487 lines, -436 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 6 months ago (2012-06-01 01:45:25 UTC) #2

lgtm!

https://chromiumcodereview.appspot.com/10442125/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10442125/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:439: class ElementCtorInfo(object):
Consistency nit: you use both "CtorInfo" and "ConstructorInfo" in various places
in this file.  Pick one.

https://chromiumcodereview.appspot.com/10442125/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:444: self.tag = tag or name
What is the difference between "tag" and "name"?  Comment on that would be
helpful.

Expand Messages | Collapse Messages