Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 10442107: Implement super read. (Closed)

Created:
8 years, 6 months ago by ahe
Modified:
8 years, 6 months ago
Reviewers:
floitsch, ngeoffray, kasperl
CC:
reviews_dartlang.org, kasperl, karlklose
Visibility:
Public.

Description

Implement super read. Committed: https://code.google.com/p/dart/source/detail?r=8140

Patch Set 1 #

Patch Set 2 : Update status files #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M dart/lib/compiler/implementation/ssa/builder.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M dart/lib/compiler/implementation/ssa/codegen.dart View 1 chunk +1 line, -1 line 2 comments Download
M dart/samples/tests/samples/samples.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M dart/tests/co19/co19-leg.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/language/language_dart2js.status View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ahe
8 years, 6 months ago (2012-05-31 05:28:30 UTC) #1
kasperl
LGTM with a test case.
8 years, 6 months ago (2012-05-31 05:30:08 UTC) #2
ahe
On 2012/05/31 05:30:08, kasperl wrote: > LGTM with a test case. I expect that I'll ...
8 years, 6 months ago (2012-05-31 05:33:54 UTC) #3
kasperl
LGTM with a status file update? :-)
8 years, 6 months ago (2012-05-31 05:35:17 UTC) #4
ahe
On 2012/05/31 05:33:54, ahe wrote: > On 2012/05/31 05:30:08, kasperl wrote: > > LGTM with ...
8 years, 6 months ago (2012-05-31 05:35:40 UTC) #5
ahe
Updated status file.
8 years, 6 months ago (2012-05-31 05:50:07 UTC) #6
ngeoffray
LGTM! Will you also do super write? https://chromiumcodereview.appspot.com/10442107/diff/5001/dart/lib/compiler/implementation/ssa/codegen.dart File dart/lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10442107/diff/5001/dart/lib/compiler/implementation/ssa/codegen.dart#newcode1564 dart/lib/compiler/implementation/ssa/codegen.dart:1564: buffer.add('$className.prototype.$methodName.call(this)'); How ...
8 years, 6 months ago (2012-05-31 07:00:57 UTC) #7
ahe
8 years, 6 months ago (2012-05-31 07:24:35 UTC) #8
Thank you, Kasper and Nicolas.

I'll also do super write.

https://chromiumcodereview.appspot.com/10442107/diff/5001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10442107/diff/5001/dart/lib/compiler/i...
dart/lib/compiler/implementation/ssa/codegen.dart:1564:
buffer.add('$className.prototype.$methodName.call(this)');
On 2012/05/31 07:00:57, ngeoffray wrote:
> How could that code have ever worked before? Is that the reason why
> mint_maker_rpc_test was failing?

I think so.

Actually,  I think I need to change it to call visitArguments.

Powered by Google App Engine
This is Rietveld 408576698