Issue 10442057: Native wrappers should implement dart:html interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10442057: Native wrappers should implement dart:html interfaces. (Closed)

Created:
8 years, 6 months ago by podivilov

Modified:
8 years, 6 months ago

Reviewers:
vsm, Anton Muhin, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Native wrappers should implement dart:html interfaces. This is the next step towards wrapperless dart:html. R=antonm@google.com,vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=8063

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -26 lines)			Patch
M	lib/dom/scripts/systemnative.py	View	2 chunks	+5 lines, -18 lines	2 comments	Download
M	lib/dom/src/native_DOMImplementation.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/dom/templates/dom/native/dart_implementation.darttemplate	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

8 years, 6 months ago (2012-05-30 00:10:46 UTC) #3

lgtm w/ comments addressed.

http://codereview.chromium.org/10442057/diff/1/lib/dom/scripts/systemnative.py
File lib/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/10442057/diff/1/lib/dom/scripts/systemnative.p...
lib/dom/scripts/systemnative.py:358: def _DartType(self, idl_type):
do we need this method at all?

http://codereview.chromium.org/10442057/diff/1/lib/dom/scripts/systemnative.p...
lib/dom/scripts/systemnative.py:360: return
self._HTMLInterfaceName(type_info.dart_type())
nit: make a one-liner?

Expand Messages | Collapse Messages