Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 10441034: Fix Dart_New so that it works with List. (Closed)

Created:
8 years, 7 months ago by turnidge
Modified:
8 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix Dart_New so that it works with List. Specifically, when some interface "I" declares a default class "C", that class "C" may either implement or not implement "I". It turns out that the name lookup is supposed to be different in these two cases. Before I only handled one of these cases correctly. Also, it turns out I was passing bogus parameters to factory constructors. I was supposed to pass type arguments, but instead I was passing the wrong thing. Fixed this. This should fix issue 2971. Committed: https://code.google.com/p/dart/source/detail?r=8072

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -32 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 2 4 chunks +49 lines, -11 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 5 chunks +113 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
8 years, 7 months ago (2012-05-24 21:58:13 UTC) #1
regis
LGTM At some time, are we going to support type arguments in the API? This ...
8 years, 7 months ago (2012-05-24 22:26:12 UTC) #2
turnidge
8 years, 6 months ago (2012-05-29 17:52:19 UTC) #3
On 2012/05/24 22:26:12, regis wrote:
> LGTM
> 
> At some time, are we going to support type arguments in the API? This would
> allow the allocation of List<String>, rather than today's List<Dynamic>.

Yes.  We plan on supporting type arguments in the api.  I haven't gotten to that
yet.

Powered by Google App Engine
This is Rietveld 408576698