Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10441014: Parameterize WorkItem.run. (Closed)

Created:
8 years, 7 months ago by ahe
Modified:
8 years, 7 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Parameterize WorkItem.run. Committed: https://code.google.com/p/dart/source/detail?r=7938

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -35 lines) Patch
M dart/frog/tests/leg/compiler_helper.dart View 1 chunk +2 lines, -1 line 1 comment Download
M dart/lib/compiler/implementation/compiler.dart View 3 chunks +10 lines, -14 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/scanner_task.dart View 2 chunks +15 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ahe
https://chromiumcodereview.appspot.com/10441014/diff/1/dart/frog/tests/leg/compiler_helper.dart File dart/frog/tests/leg/compiler_helper.dart (right): https://chromiumcodereview.appspot.com/10441014/diff/1/dart/frog/tests/leg/compiler_helper.dart#newcode21 dart/frog/tests/leg/compiler_helper.dart:21: String generated = work.run(compiler, compiler.enqueuer.codegen); You already reviewed the ...
8 years, 7 months ago (2012-05-24 07:24:48 UTC) #1
ngeoffray
8 years, 7 months ago (2012-05-24 07:26:15 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698