Issue 10440082: Fix a bug in ia32 shift left , implemented more inlined binary operations in x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10440082: Fix a bug in ia32 shift left , implemented more inlined binary operations in x64. (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a bug in ia32 shift left , implemented more inlined binary operations in x64. Committed: https://code.google.com/p/dart/source/detail?r=8119

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -22 lines)			Patch
M	runtime/vm/constants_ia32.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/constants_x64.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	2 chunks	+1 line, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	3 chunks	+138 lines, -10 lines	0 comments	Download
M	runtime/vm/locations.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/token.h	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/token.cc	View	1 2	2 chunks	+31 lines, -0 lines	0 comments	Download
M	tests/language/bit_operations_test.dart	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://chromiumcodereview.appspot.com/10440082/diff/8001/runtime/vm/intermediate_language_x64.cc File runtime/vm/intermediate_language_x64.cc (right): https://chromiumcodereview.appspot.com/10440082/diff/8001/runtime/vm/intermediate_language_x64.cc#newcode990 runtime/vm/intermediate_language_x64.cc:990: case Token::kBIT_OR: { Maybe also add the same ...

8 years, 6 months ago (2012-05-30 14:21:12 UTC) #2

srdjan

8 years, 6 months ago (2012-05-30 17:03:10 UTC) #3

https://chromiumcodereview.appspot.com/10440082/diff/8001/runtime/vm/intermed...
File runtime/vm/intermediate_language_x64.cc (right):

https://chromiumcodereview.appspot.com/10440082/diff/8001/runtime/vm/intermed...
runtime/vm/intermediate_language_x64.cc:990: case Token::kBIT_OR: {
On 2012/05/30 14:21:12, Florian Schneider wrote:
> Maybe also add the same comment as in the BIT_AND and XOR case, or leave them
> all out.

Added it.

Expand Messages | Collapse Messages

Issue 10440082: Fix a bug in ia32 shift left , implemented more inlined binary operations in x64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages