Fix erroneous asynchronous code in test scripts (batch runner).

Fix erroneous asynchronous code in test scripts (batch runner).

BUG=3286
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=8058

[ahe, 2012-05-29 13:19:37]

DBC

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:644: * closures need a shared value, that
they can all change and read.
I see what you're doing with this class, but I must admit it looks like a hack.

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:665: MutableValue<bool> _ignoreStreams;
Why can't this not just be:

bool _ignoreStreams;

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:733: _ignoreStreams = new
MutableValue<bool>(false);  // Captured by closures.
There are no local variables here, so nothing is being captured by a closure.

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:780: return;
Tab character.

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:798: _stdoutDone();
Tab.

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:804: var ignoreStreams = _ignoreStreams;  //
Capture this mutable object.
This seems like a hack to me.

[Mads Ager (google), 2012-05-29 13:24:34]

LGTM

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:780: return;
tab?

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:798: _stdoutDone();
tab?

http://codereview.chromium.org/10440071/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:815: if (ignoreStreams.value) continue;
Is this needed? Nothing else should happen that can change the value while you
are doing this synchronous loop?