Issue 10440044: Process exit code handling reworked for Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10440044: Process exit code handling reworked for Windows. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)

Modified:
8 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Process exit code handling reworked for Windows. Simplify the code by relying on the builtin Windows thread pool to wait for all process handles. The additional benefit is that we can have an arbitrary number of processes and are not restricted by the max number of handles for WaitForMultipleObjects. R=sgjesse@google.com BUG=dartbug:1450 TEST=standalone/io/process_many_test.dart Committed: https://code.google.com/p/dart/source/detail?r=7995

Patch Set 1 #

Patch Set 2 : Actually unregister wait operation #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -244 lines)			Patch
M	runtime/bin/process_win.cc	View	1	8 chunks	+87 lines, -244 lines	0 comments	Download
A	tests/standalone/io/process_many_script.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	tests/standalone/io/process_many_test.dart	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Simplification FTW!

Expand Messages | Collapse Messages